Configure ink drops on menu bar buttons #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
changed the title
|
There are a few cpplint warnings, other parts are good to me. |
kevinsawicki
force-pushed
the
ink-drop-on-system-menu
branch
2 times, most recently
from
b00ac40
to
bc8580b
Compare
kevinsawicki
force-pushed
the
ink-drop-on-system-menu
branch
from
bc8580b
to
8e2f35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.4 upgrade to Chrome 53 caused the menu bar buttons to no longer show hover/click states on Windows and Linux.
This pull request updates them to use the new ink drop effects that Chrome now uses for buttons to show feedback for press and hover.
Closes #7279